Tomas Jelinek has posted comments on this change.
Change subject: webadmin, userportal: cloud-init [5/6] - add to run vm once
dialog
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(4 inline comments)
mostly cosmetical comments, otherwise looks ok. If fixed I will give +2
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/CloudInitWidget.ui.xml
Line 49: background-color: #444444;
Line 50: }
Line 51: </ui:style>
Line 52:
Line 53: <g:VerticalPanel ui:field="cloudInitOptions">
Well, VerticalPanel and HorizontalPanel are widgets which are rendered as HTML
tables which is not ideal. We are trying to get rid of this widgets - in new
code please try to use FlowPanel (which is div) with due CSS to render your
widgets.
Line 54: <g:HorizontalPanel>
Line 55: <e:EntityModelCheckBoxEditor
ui:field="hostnameEnabledEditor" addStyleNames="{style.optionCheckbox}" />
Line 56: <e:EntityModelTextBoxEditor
ui:field="hostnameEditor" addStyleNames="{style.primaryOption}" />
Line 57: </g:HorizontalPanel>
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml
Line 188:
<e:EntityModelTextBoxEditor ui:field="sysPrepUserNameEditor"
addStyleNames="{style.sysprepOption}" />
Line 189:
<e:EntityModelTextBoxEditor ui:field="sysPrepPasswordEditor"
addStyleNames="{style.sysprepOption}" />
Line 190: </g:VerticalPanel>
Line 191: </g:VerticalPanel>
Line 192:
please remove blankspace
Line 193: <g:VerticalPanel ui:field="cloudInitSubPanel"
addStyleNames="{style.initialRunPanel}">
Line 194: <g:Label
addStyleNames="{style.initialRunSubPanelLabel}"
text="{constants.runOncePopupCloudInitLabel}" />
Line 195: <g:Label
ui:field="cloudInitToEnableLabel" addStyleNames="{style.cloudInitOption}" />
Line 196: <vm:CloudInitWidget
ui:field="cloudInitWidget"/>
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloudInitModel.java
Line 376: getRegenerateKeysEnabled().setEntity(Boolean.FALSE);
Line 377: getTimeZoneEnabled().setEntity(Boolean.FALSE);
Line 378: getRootPasswordEnabled().setEntity(Boolean.FALSE);
Line 379: getNetworkEnabled().setEntity(Boolean.FALSE);
Line 380: getAttachmentEnabled().setEntity(Boolean.FALSE);
primitive false would make it thanx to autoboxing.
Line 381:
Line 382: AsyncDataProvider.getTimeZoneList(new AsyncQuery(this, new
INewAsyncCallback() {
Line 383: @Override
Line 384: public void onSuccess(Object model, Object returnValue) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 573: setSysPrepPassword(new EntityModel().setIsChangable(false));
Line 574:
Line 575: setIsSysprepEnabled(new EntityModel());
Line 576: setIsSysprepPossible(new EntityModel());
Line 577: EntityModel tempVar3 = new EntityModel();
the tempVar3 is not used [and also if it would it has not a too well crafted
name :) ]
Line 578: setIsVmFirstRun(new EntityModel(false));
Line 579: getIsVmFirstRun().getEntityChangedEvent().addListener(this);
Line 580: setUseAlternateCredentials(new EntityModel(false));
Line 581:
getUseAlternateCredentials().getEntityChangedEvent().addListener(this);
--
To view, visit http://gerrit.ovirt.org/14351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c46ebb41ac97ecf08168c215911761e0fc497fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
