Roy Golan has posted comments on this change.

Change subject: core: Manage OS properties in a repository
......................................................................


Patch Set 10: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java
Line 11: 
Line 12:     @Override
Line 13:     protected void executeQueryCommand() {
Line 14:         switch (getParameters().getOsRepositoryVerb()) {
Line 15:             case GetOsNames:
Done
Line 16:                 setReturnValue(OsRepositoryImpl.INSTANCE.getOsNames());
Line 17:                 break;
Line 18:             case GetUniqueOsNames:
Line 19:                 
setReturnValue(OsRepositoryImpl.INSTANCE.getUniqueOsNames());


Line 20:                 break;
Line 21:             case GetOSIds:
Line 22:                 setReturnValue(OsRepositoryImpl.INSTANCE.getOsIds());
Line 23:                 break;
Line 24:             case GetlinuxOSs:
Done
Line 25:                 
setReturnValue(OsRepositoryImpl.INSTANCE.getLinuxOSs());
Line 26:                 break;
Line 27:             case GetWindowsOSs:
Line 28:                 
setReturnValue(OsRepositoryImpl.INSTANCE.getWindowsOss());


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
Line 40: 
Line 41:     /**
Line 42:      * @return a list of OSs who's {@link 
OsRepository#getOsFamily(int)} returns "linux"
Line 43:      */
Line 44:     public ArrayList<Integer> getLinuxOSs();
Done
Line 45: 
Line 46:     public ArrayList<Integer> get64bitOss();
Line 47: 
Line 48:     /**


-- 
To view, visit http://gerrit.ovirt.org/15080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50384bf3b6763fa7a34badc2449e06242186a858
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to