Moti Asayag has posted comments on this change. Change subject: engine: Fix unit tests that were broken by multiple gateways ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java Line 172: nic.setBootProtocol(NetworkBootProtocol.STATIC_IP); Line 173: nic.setGateway(RandomUtils.instance().nextString(10)); Line 174: mockExistingIfaces(nic); Line 175: nic.setGateway(RandomUtils.instance().nextString(10)); Line 176: In that case, would you add another test which should fail for using setupNetworks to update a gateway for a version earlier than 3.3 ? Line 177: VDS vds = mock(VDS.class); Line 178: when(vds.getId()).thenReturn(Guid.Empty); Line 179: when(vds.getVdsGroupCompatibilityVersion()).thenReturn(Version.v3_3); Line 180: -- To view, visit http://gerrit.ovirt.org/15493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d453ea1efe736dd16dea9b793d784bee4225af8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
