Mike Kolesnik has posted comments on this change.
Change subject: core: add the openstack dependency
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1328: ClientModeSpiceDefault(501),
Line 1329:
Line 1330: @TypeConverterAttribute(String.class)
Line 1331: @DefaultValueAttribute("Auto")
Line 1332: KeystoneAuthUrl(424),
Please notice that 424 id is already taken..
Line 1333:
Line 1334: @TypeConverterAttribute(Boolean.class)
Line 1335: @DefaultValueAttribute("false")
Line 1336: MigrationNetworkEnabled(502),
....................................................
File backend/manager/modules/utils/pom.xml
Line 141: <dependency>
Line 142: <groupId>org.infinispan</groupId>
Line 143: <artifactId>infinispan-core</artifactId>
Line 144: </dependency>
Line 145:
Not sure that this is necessary any more?
Line 146: <dependency>
Line 147: <groupId>com.woorea</groupId>
Line 148: <artifactId>keystone-client</artifactId>
Line 149: <version>${openstack-client.version}</version>
--
To view, visit http://gerrit.ovirt.org/13434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib516b48ba9c7e3b9bbc657fe970361a484221e88
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
