Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: Fix failing unit tests ......................................................................
Patch Set 3: Verified Improved patch with regard to init method: * no-arg init method is called by Servlet container * init method with args is called by unit test (package-private visibility is sufficient) Servlet dependencies are injected via init method with args. This avoids the need for setters that would only be used by unit test. -- To view, visit http://gerrit.ovirt.org/15575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ad20a52daa459188e15e512bb78c97a07364cbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
