Omer Frenkel has posted comments on this change.
Change subject: core: Fail tasks that dont have Vdsm Id
......................................................................
Patch Set 24: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 218: ExecutionContext context = null;
Line 219: if (stepId != null) {
Line 220: context =
ExecutionHandler.createFinalizingContext(stepId.getValue());
Line 221: }
Line 222: Backend.getInstance().endAction(task.getaction_type(),
is it ok to call end action if only one (or part) of the actions does not have
vdsmId?
what will happen with other running tasks?
Line 223: task.getActionParameters(),
Line 224: new CommandContext(context));
Line 225: }
Line 226:
--
To view, visit http://gerrit.ovirt.org/14368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I110c483842027d1596f64dd8c3f635d62924a93f
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
