Laszlo Hornyak has posted comments on this change.
Change subject: engine: watchdog - restapi support
......................................................................
Patch Set 32: (6 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2415: </xs:sequence>
Line 2416: </xs:extension>
Line 2417: </xs:complexContent>
Line 2418: </xs:complexType>
Line 2419:
Done
Line 2420: <xs:element name="watchdog" type="WatchDog"/>
Line 2421:
Line 2422: <xs:element name="watchdogs" type="WatchDogs"/>
Line 2423:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 250: }
Line 251: }
Line 252:
Line 253: private void addWatchdogActions(VersionCaps version,
WatchdogAction[] values) {
Line 254: if (VersionUtils.greaterOrEqual(version, VERSION_3_2)) {
Done
Line 255: version.setWatchdogActions(new WatchdogActions());
Line 256: for (WatchdogAction watchdogAction : values) {
Line 257:
version.getWatchdogActions().getWatchdogActions().add(watchdogAction.value());
Line 258: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 140: new
IdQueryParameters(guid)));
Line 141: }
Line 142:
Line 143: @Override
Line 144: public DevicesResource<WatchDog, WatchDogs>
getWatchdogsResource() {
Done
Line 145: return inject(new BackendWatchdogsResource(guid,
Line 146:
VdcQueryType.GetWatchdog,
Line 147: new
IdQueryParameters(guid)));
Line 148: }
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/validation/WatchdogValidatorTest.java
Line 25: @Test()
Line 26: public void validateEnums() {
Line 27: WatchDog entity = new WatchDog();
Line 28: entity.setAction("reset");
Line 29: entity.setModel("i6300esb");
in that case if someone breaks the enum we will have the test still running, so
only the integration tests may spot the problem
Line 30: new WatchdogValidator().validateEnums(entity);
Line 31: }
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 964: VmWatchdog entity = template ==null ? new VmWatchdog() :
template;
Line 965: entity.setAction(model.getAction());
Line 966: entity.setModel(model.getModel());
Line 967: return entity;
Line 968: }*/
Done
Line 969:
Line 970: static String cpuTuneToString(final CpuTune tune) {
Line 971: final StringBuilder builder = new StringBuilder();
Line 972: boolean first = true;
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/WatchdogMapperTest.java
Line 25: @Test
Line 26: public void mapWatchdog() {
Line 27: WatchDog model = new WatchDog();
Line 28: model.setAction("reset");
Line 29: model.setModel("i6300esb");
not done
Line 30: model.setId(new Guid().toString());
Line 31: VmWatchdog entity = WatchdogMapper.map(model, null);
Line 32: Assert.assertNotNull(entity);
Line 33: Assert.assertEquals(entity.getAction(),
VmWatchdogAction.RESET);
--
To view, visit http://gerrit.ovirt.org/13060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief5b20ecf2221faf900cadfeafe4c71607a9eca3
Gerrit-PatchSet: 32
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
