Alon Bar-Lev has posted comments on this change.
Change subject: [WIP] Introduce new authenticator interface
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/auth/Authenticator.java
Line 13: * for example, if the underlying mechanism is Kerberos then the
name of the
Line 14: * authenticator should be the name of the Kerberos realm, however
this is
Line 15: * not enforced.
Line 16: */
Line 17: String getName();
it should be based on the name and the profile...
So if I have 4 kerberos profiles I can register them all using the same class.
No?
Line 18:
Line 19: /**
Line 20: * Verifies that the given credentials are valid.
Line 21: *
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/auth/AuthenticatorManager.java
Line 94: if (StringUtils.equals(authenticator.getName(), name))
{
Line 95: return authenticator;
Line 96: }
Line 97: }
Line 98: }
I am missing the whole profile management... both here in at the directory.
Authenticator is implementation instantiate over some configuration.
Am I missing something?
Line 99:
Line 100: // No luck, no authenticator matches the given name:
Line 101: log.warn(
Line 102: "There is no instance to manage authenticator \"" + name +
--
To view, visit http://gerrit.ovirt.org/15597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11635c21917401ac7c882fa3233010c804dfb91f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
