Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Corrected event log msg for add brick
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 104: }
Line 105:
Line 106: private void logAuditMessages(List<GlusterBrickEntity> bricks) {
Line 107: GlusterAuditLogUtil logUtil =
GlusterAuditLogUtil.getInstance();
Line 108: for (final GlusterBrickEntity brick : bricks) {
How long can be the brick list?
What happens if server crashes in the middle?
You might have a partial list in db.
These things should be done somehow in single transaction.
Line 109: logUtil.logAuditMessage(null,
Line 110: null,
Line 111: null,
Line 112: AuditLogType.GLUSTER_VOLUME_BRICK_ADDED,
--
To view, visit http://gerrit.ovirt.org/15664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05054de122a916d25c14adc05efdc484a0c133f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
