Omer Frenkel has posted comments on this change.
Change subject: gluster: Corrected the event log message
......................................................................
Patch Set 6: (1 inline comment)
minor suggestion inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
Line 56: isResetAllOptions = false;
Line 57: if(entity != null) {
Line 58: String optionValue = entity.getValue();
Line 59:
getParameters().getVolumeOption().setValue(optionValue != null ? optionValue :
"");
Line 60: }
why do you need to override getCustomValues() instead of just adding the custom
values here? with the override it will affect also command inheriting from this
command.
Line 61: } else {
Line 62: for (GlusterVolumeOptionEntity option :
getGlusterVolume().getOptions()) {
Line 63: removeOptionInDb(option);
Line 64: }
--
To view, visit http://gerrit.ovirt.org/14884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd53a3f6a0ef671562a510275d6dd54417669545
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
