Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: fix pep8 issues ......................................................................
packaging: fix pep8 issues Change-Id: Iddd48d9656750ecbe3bb6c4ee062f31e17e880f6 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/services/ovirt-engine-notifier.py M packaging/services/ovirt-engine.py M packaging/setup/ovirt_engine_setup/database.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 4 files changed, 10 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/15759/1 diff --git a/packaging/services/ovirt-engine-notifier.py b/packaging/services/ovirt-engine-notifier.py index 530c211..bd31ceb 100755 --- a/packaging/services/ovirt-engine-notifier.py +++ b/packaging/services/ovirt-engine-notifier.py @@ -143,7 +143,10 @@ self._engineEnv = os.environ.copy() self._engineEnv.update({ - 'PATH': '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', + 'PATH': ( + '/usr/local/sbin:/usr/local/bin:' + '/usr/sbin:/usr/bin:/sbin:/bin' + ), 'LANG': 'en_US.UTF-8', 'LC_ALL': 'en_US.UTF-8', 'CLASSPATH': '', diff --git a/packaging/services/ovirt-engine.py b/packaging/services/ovirt-engine.py index 9a75536..fd4205c 100755 --- a/packaging/services/ovirt-engine.py +++ b/packaging/services/ovirt-engine.py @@ -406,7 +406,10 @@ self._engineEnv = os.environ.copy() self._engineEnv.update({ - 'PATH': '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin', + 'PATH': ( + '/usr/local/sbin:/usr/local/bin:' + '/usr/sbin:/usr/bin:/sbin:/bin' + ), 'LANG': 'en_US.UTF-8', 'LC_ALL': 'en_US.UTF-8', 'ENGINE_DEFAULTS': config.ENGINE_DEFAULT_FILE, diff --git a/packaging/setup/ovirt_engine_setup/database.py b/packaging/setup/ovirt_engine_setup/database.py index c178339..68e2da7 100644 --- a/packaging/setup/ovirt_engine_setup/database.py +++ b/packaging/setup/ovirt_engine_setup/database.py @@ -69,11 +69,13 @@ return connection.autocommit else: return connection.isolation_level + def __restore_autocommit(connection, v): if hasattr(connection, 'autocommit'): connection.autocommit = v else: connection.set_isolation_level(v) + def __set_autocommit(connection, autocommit): if hasattr(connection, 'autocommit'): connection.autocommit = autocommit diff --git a/packaging/setup/plugins/ovirt-engine-setup/pki/ca.py b/packaging/setup/plugins/ovirt-engine-setup/pki/ca.py index be6f789..c9df498 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/pki/ca.py +++ b/packaging/setup/plugins/ovirt-engine-setup/pki/ca.py @@ -20,7 +20,6 @@ import os -import datetime import random import gettext _ = lambda m: gettext.dgettext(message=m, domain='ovirt-engine-setup') -- To view, visit http://gerrit.ovirt.org/15759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddd48d9656750ecbe3bb6c4ee062f31e17e880f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
