Allon Mureinik has posted comments on this change.
Change subject: 7. core: Change CreateAllSnapshotsFromVmCommand to persist all
placeholders
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 64: @LockIdNameAttribute(isReleaseAtEndOfExecute = false)
Line 65: public class CreateAllSnapshotsFromVmCommand<T extends
CreateAllSnapshotsFromVmParameters> extends VmCommand<T> implements
QuotaStorageDependent, TaskHandlerCommand<CreateAllSnapshotsFromVmParameters> {
Line 66:
Line 67: private List<DiskImage> cachedSelectedActiveDisks;
Line 68: private Map<Guid, CommandBase<?>> commandsMap = new HashMap<>();
I really don't like to have to redefine this map for every command. Why can't
we have one in CommandBase?
Line 69: private Guid cachedStorageDomainId = Guid.Empty;
Line 70: /** flag that indicates whether memory snapshot is about to be
created */
Line 71: private boolean prepareForMemorySnapshot;
Line 72: private String cachedSnapshotIsBeingTakenMessage;
--
To view, visit http://gerrit.ovirt.org/15563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0dda1086792f40a487488ac8a02b6b89dcfa9da
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
