Allon Mureinik has posted comments on this change.
Change subject: 13. core: Introducing "end command coordination" by command Id
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
Line 23: /**
Line 24: * Base class for all tasks regarding a specific command.
Line 25: */
Line 26: public class EntityAsyncTask extends SPMAsyncTask {
Line 27: private static final Object _lockObject = new Object();
I don't get this lock object.
Wouldn't a ConcurrentHashMap do the trick?
What am I missing?
Line 28:
Line 29: private static final Map<Guid, EntityMultiAsyncTasks>
_multiTasksByCommandIds =
Line 30: new HashMap<Guid, EntityMultiAsyncTasks>();
Line 31:
....................................................
Commit Message
Line 8:
Line 9: The following patch changes EntityAsyncTask and EntityMultiAsyncTasks
Line 10: to perform tasks completion coordination (in order to run endAction)
based
Line 11: on command Ids (the parent command Id), and not the entity Id
Line 12:
Please add a link to the feature page
Line 13: Change-Id: I53999748c791aae04287efaa01c10ea7037e5ff2
--
To view, visit http://gerrit.ovirt.org/15569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53999748c791aae04287efaa01c10ea7037e5ff2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
