Allon Mureinik has posted comments on this change.
Change subject: core: RegisterDiskCommand - fix and refactor CDA
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
Line 95:
Line 96: @JsonIgnore
Line 97: public boolean isDataDomain() {
Line 98: return StorageDomainType.Data.equals(getStorageDomainType()) ||
Line 99:
StorageDomainType.Master.equals(getStorageDomainType());
this method should be a part of StorageDomainType
Line 100: }
Line 101:
Line 102: @Override
Line 103: public Guid getId() {
--
To view, visit http://gerrit.ovirt.org/15210
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie96fae8717053435eb1df62217ea3c1469c4768c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
