Hello Gilad Chaplik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/15820
to review the following change.
Change subject: core: VdsSelector: remove method used only once
......................................................................
core: VdsSelector: remove method used only once
Removing method: 'canFindAnyVds(List, boolean)'.
To improve code readability.
Gerrit-cntr: 1
Change-Id: Ie05b7dfd98f9cd26e9158cd0ce7c2a958cd6bc8e
Signed-off-by: Gilad Chaplik <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/15820/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
index d8e629e..57cb912 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/VdsSelector.java
@@ -107,7 +107,8 @@
return false;
}
- returnValue = canFindAnyVds(messages, isMigrate);
+ returnValue = canFindVdsToRun(messages, isMigrate,
+ DbFacade.getInstance().getVdsDao().getAllOfTypes(new
VDSType[] { VDSType.VDS, VDSType.oVirtNode }));
}
return returnValue;
@@ -117,11 +118,6 @@
return getVdsToRunOn(DbFacade.getInstance()
.getVdsDao()
.getAllOfTypes(new VDSType[] { VDSType.VDS, VDSType.oVirtNode
}), isMigrate);
- }
-
- private boolean canFindAnyVds(List<String> messages, boolean isMigrate) {
- return canFindVdsToRun(messages, isMigrate,
- DbFacade.getInstance().getVdsDao().getAllOfTypes(new VDSType[]
{ VDSType.VDS, VDSType.oVirtNode }));
}
/**
--
To view, visit http://gerrit.ovirt.org/15820
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie05b7dfd98f9cd26e9158cd0ce7c2a958cd6bc8e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
