Lior Vernia has posted comments on this change.
Change subject: webadmin: Moved provider discovery logic to popup
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderNetworkListModel.java
Line 93: return;
Line 94: }
Line 95: DiscoverNetworksModel discoverModel = new
DiscoverNetworksModel(this, getEntity());
Line 96: setWindow(discoverModel);
Line 97: discoverModel.initBackendData();
Because this is an action that could actually fail (it depends on the
accessibility of Provider server), and if there's a backend error I want it to
display in a popup for the user to understand what happened. Since the popup is
only displayed after the constructor has finished running, I couldn't call this
from the constructor and have the error displayed in a popup.
Line 98: }
Line 99:
Line 100: public void add() {
Line 101: if (getWindow() != null) {
--
To view, visit http://gerrit.ovirt.org/15029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06a8acf5ecfdc0db8b2f0c73441c6367b5c3dc0f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
