Moti Asayag has posted comments on this change.
Change subject: engine: Added provider network for run & stop VM
......................................................................
Patch Set 23: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 464: @SuppressWarnings("unchecked")
Line 465: protected void handleProviderNetworks() {
Line 466: Map<String, Network> clusterNetworks =
Line 467:
Entities.entitiesByName(getDbFacade().getNetworkDao().getAllForCluster(getVm().getVdsGroupId()));
Line 468: Map<VmDeviceId, VmDevice> nicDevices =
you can revert the order of the queries and if the VM has no nics, early quit
from the method instead of fetching the cluster's networks
Line 469:
Entities.businessEntitiesById(getDbFacade().getVmDeviceDao().getVmDeviceByVmIdAndType(getVmId(),
Line 470: VmDeviceGeneralType.INTERFACE));
Line 471:
Line 472: for (VmNetworkInterface iface : getVm().getInterfaces()) {
Line 481:
getDbFacade().getProviderDao().get(network.getProvidedBy().getProviderId());
Line 482: NetworkProviderProxy providerProxy =
ProviderProxyFactory.getInstance().create(provider);
Line 483: String vNicId = providerProxy.allocate(network,
iface);
Line 484: if (vNicId != null) {
Line 485: Map<String, String> runtimeProperties = new
HashMap<>();
please extract to constants.
Line 486: runtimeProperties.put("vnic_id", vNicId);
Line 487: runtimeProperties.put("provider_type",
provider.getType().name());
Line 488: runtimeProperties.put("plugin_type",
provider.getAdditionalProperties().getPluginType().name());
Line 489:
getVm().getRuntimeDeviceCustomProperties().put(vmDevice, runtimeProperties);
--
To view, visit http://gerrit.ovirt.org/11032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b100ddad9ea88e07980ada116c19e42ca2b2c8a
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
