Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: Serve static content with web server ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) Some minor comments inline plus following suggestion: * UI plugin static resources must be served via Engine, i.e. /webadmin/webadmin/plugin/* * branding resources must be served via Engine, i.e. /webadmin/theme/* + /UserPortal/theme/* Otherwise, the patch looks good. .................................................... File packaging/conf/ovirt-engine-proxy.conf.in Line 95: Line 96: # Caching for GWT resources: Line 97: <IfModule expires_module> Line 98: <IfModule headers_module> Line 99: <Files *.cache.*> In addition to *.cache.* files, we should also cache *.css *.gif *.png Line 100: ExpiresActive On Line 101: ExpiresDefault "now plus 1 year" Line 102: Header merge Cache-Control "public" Line 103: Header set Pragma "" Line 148: Line 149: # Caching for GWT resources: Line 150: <IfModule expires_module> Line 151: <IfModule headers_module> Line 152: <Files *.cache.*> In addition to *.cache.* files, we should also cache *.css *.gif *.png Line 153: ExpiresActive On Line 154: ExpiresDefault "now plus 1 year" Line 155: Header merge Cache-Control "public" Line 156: Header set Pragma "" -- To view, visit http://gerrit.ovirt.org/11762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I725ef50beb223b5bb38d48ea93dc1ea8b406b12e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
