Cheryn Tan has posted comments on this change.
Change subject: core: add validation to AddStorageServerConnection
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 341: ACTION_TYPE_FAILED_NAME_ALREADY_USED=Cannot ${action} ${type}. The
${type} name is already in use, please choose a unique name and try again.
Line 342: ACTION_TYPE_FAILED_URL_INVALID=Cannot ${action} ${type}. The URL is
not valid, please enter a valid URL and try again.
Line 343: ACTION_TYPE_FAILED_STORAGE_CONNECTION_NOT_EXIST=Cannot ${action}
${type}. Storage connection doesn't exist.
Line 344: ACTION_TYPE_FAILED_STORAGE_CONNECTION_ID_EMPTY=Cannot ${action}
${type}. Storage connection id is empty.
Line 345: ACTION_TYPE_FAILED_STORAGE_CONNECTION_ID_NOT_EMPTY=Cannot ${action}
${type}. Storage connection id is not empty.
Okay, if it's an edge case I think the message is sufficient. Thank you for the
detailed reply Alissa!
Line 346: ACTION_TYPE_FAILED_STORAGE_CONNECTION_ALREADY_EXISTS=Cannot ${action}
${type}. Storage connection already exists.
Line 347:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_ACTION_FOR_STORAGE=Cannot
${action} ${type}. Storage connection parameters can be edited only for NFS
data domains in maintenance.
Line 348:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_BELONGS_TO_SEVERAL_STORAGE_DOMAINS=Cannot
${action} ${type}. Cannot ${action} ${type}. Storage connection parameters are
related to the following storage domains : ${domainNames}.
Line 349:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_BELONGS_TO_SEVERAL_STORAGE_DOMAINS_AND_DISKS=Cannot
${action} ${type}. Storage connection parameters are related to the following
storage domains : ${domainNames} and disks: ${diskNames}.
--
To view, visit http://gerrit.ovirt.org/15388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9bcef8a413589654d36db8d878c844550ae6066
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
