Allon Mureinik has posted comments on this change.
Change subject: core: Add snapshot validation for empty guid.
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 116: getVmTemplate().setImages(images);
Line 117: ensureDomainMap(getParameters().getImages(),
getParameters().getDestDomainId());
Line 118: Map<Guid, DiskImage> imageMap = new HashMap<Guid,
DiskImage>();
Line 119: for (DiskImage image : images) {
Line 120: if (Guid.Empty.equals(image.getVmSnapshotId())) {
why is this relevant for templates?
Line 121: retVal =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CORRUPTED_VM_SNAPSHOT_ID);
Line 122: break;
Line 123: }
Line 124:
--
To view, visit http://gerrit.ovirt.org/15701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19bc2982adecca198f8dc38ca011f4528dd58db9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
