Itamar Heim has posted comments on this change. Change subject: core: Add supportedEmulatedMachines to Host model cluster ......................................................................
Patch Set 1: >>I'm missing why you don't set the new default value per cluster based on the >>current first value in the EmulatedMachine config per cluster version This means that if we want auto-setting by the first host, the first value must be '' (empty or null). IH: yes. that's how cpu matching works as well for default cluster. '','rhel6.3.0','pc-1.2' So the auto-set feature becomes optional. Maybe this is what you meant in the first place but I missed that. IH: the auto-set feature is not optional for new clusters. i'm talking about cleaning this up during upgrade. >> (then delete that value which is no longer supported, which i also missed >> seeing). I didn't supply an update yet, just a read-only field in the UI. IH: I was referring to removing the EmulatedMachine config values? -- To view, visit http://gerrit.ovirt.org/15864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25df8376026f3e5f57ce85d8e7a20e5000ce7eed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
