Allon Mureinik has posted comments on this change.
Change subject: 11. core: Adding the ability to get async tasks by entity id
......................................................................
Patch Set 16: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File backend/manager/dbscripts/async_tasks_sp.sql
Line 163: Create or replace FUNCTION GetAsyncTasksByEntityId(v_entity_id UUID)
RETURNS SETOF async_tasks
Line 164: AS $procedure$
Line 165: BEGIN
Line 166: RETURN QUERY SELECT *
Line 167: FROM async_tasks JOIN async_tasks_entities ON async_task_id =
task_id
Please put the join on a new line, below the from
Line 168: WHERE entity_id = v_entity_id;
Line 169:
Line 170: END; $procedure$
Line 171: LANGUAGE plpgsql;
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
Line 205:
Line 206: @Override
Line 207: public List<AsyncTasks> getTasksByEntity(Guid entityId) {
Line 208: MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource();
Line 209: parameterSource.addValue("entity_id", entityId);
I'd inline this - MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource().addValue("entity_id", entityId);
Line 210: return
getCallsHandler().executeReadList("GetAsyncTasksByEntityId",
Line 211: AsyncTaskRowMapper.instance,
Line 212: parameterSource);
Line 213: }
--
To view, visit http://gerrit.ovirt.org/15566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7609857273bf8ac74557ba88550dee8316eb5c7
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
