Allon Mureinik has uploaded a new change for review. Change subject: core: Fix modifiers of getStrRepresentationOfGuid ......................................................................
core: Fix modifiers of getStrRepresentationOfGuid This method is not used outside of the Guid class, and hence should be private. It also does not access any member variables, so it should be static. Change-Id: I7ca9ed63077fc5a7c39c38900780afd14126fffc Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/15884/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java index 075bad8..255fdb2 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java @@ -112,7 +112,7 @@ * ActiveDirectory) it should be kept. * @return String representation of GUID */ - public String getStrRepresentationOfGuid(byte[] inguid, + private static String getStrRepresentationOfGuid(byte[] inguid, boolean keepByteOrder) { StringBuilder strGUID = new StringBuilder(); -- To view, visit http://gerrit.ovirt.org/15884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ca9ed63077fc5a7c39c38900780afd14126fffc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
