Alon Bar-Lev has posted comments on this change.
Change subject: Log setup events
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File packaging/bin/ovirt-engine-log-setup-event.sh.in
Line 47: notes="${v}"
Line 48: ;;
Line 49: --help)
Line 50: usage
Line 51: exit
exit 0?
Line 52: ;;
Line 53: *)
Line 54: usage
Line 55: die "Invalid option '${x}'"
Line 51: exit
Line 52: ;;
Line 53: *)
Line 54: usage
Line 55: die "Invalid option '${x}'"
not better?
echo "invalid..."
usage
exit 1
Line 56: ;;
Line 57: esac
Line 58: done
Line 59:
Line 61: echo SETUP-EVENT-BEGIN
Line 62: echo DATE: $(date +'%Y-%m-%d %H:%M:%S')
Line 63: echo NOTES: ${notes}
Line 64: rpm -qa --last | \
Line 65: egrep
'^ovirt|^jboss|^libvirt|^java|^jpackage|^python-cheetah|^postgres' | \
I would avoided egrep... not that it is important... and I think we should show
all packages as we never know what is relevant.
but in any case... please indent...
command
rpm -qa --list | \
egrep ... | \
.... \
.... \
.... \
.... \
sed ...
command
Line 66: sort | \
Line 67: sed 's/^/PACKAGE: /'
Line 68: echo SETUP-EVENT-END
....................................................
File packaging/setup/plugins/ovirt-engine-common/distro-rpm/log_setup_event.py
Line 78: '--notes=End of otopi - plugin groups ' +
Line 79: self.environment[otopicons.BaseEnv.PLUGIN_GROUPS],
Line 80: ),
Line 81: )
Line 82:
one more space please, per pep8...
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/misc.py
Line 67
Line 68
Line 69
Line 70
Line 71
please keep.
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
