Vojtech Szocs has posted comments on this change.
Change subject: Introducing ui-vdsm-hooks plugin
......................................................................
Patch Set 2: Looks good to me, approved
(2 inline comments)
Very nice plugin! Just some minor comments, but other than that, looks awesome.
....................................................
File ui-vdsm-hooks-plugin/ui-vdsm-hooks-files/start.html
Line 25: var url = getCgiUrl(arguments[0],
command, args);
Line 26: var dialogToken = "hook-dialog";
Line 27: api.showDialog(title, dialogToken, url,
width || "500px", height || "400px",
Line 28: {
Line 29: resizeEnabled: true,
Some browsers might be picky about trailing comma, I suggest to remove it, just
to be on safe side.
Line 30: }
Line 31: );
Line 32: },
Line 33: isEnabled : function() {
Line 39:
Line 40: // Get 'CGI' scripts URL using specified host address
Line 41: var getCgiUrl = function(selectedHost, command, args) {
Line 42: var hostAddress = selectedHost.hostname;
Line 43: var cgiUrl = 'http://' + hostAddress + config.cgiUrl +
"?command=" + command + "&args=" + args;
In case "args" is undefined, you can do: ... + (args || "")
Line 44:
Line 45: return cgiUrl;
Line 46: }
Line 47: </script>
--
To view, visit http://gerrit.ovirt.org/15477
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1531e41eb87f33a7961a9d9ceb5f8a03c12a8cba
Gerrit-PatchSet: 2
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
