Sahina Bose has posted comments on this change.
Change subject: gluster: Host detach case sync message corrected
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java
Line 46:
Line 47: AuditLogableBase logable = new AuditLogableBase();
Line 48: logable.setVds(server);
Line 49: logable.setGlusterVolume(volume);
Line 50: logable.setVdsGroupId(clusterId == null ?
server.getVdsGroupId() : clusterId);
When would clusterId be null? I think logServerMessage should be changed to
pass clusterId
Line 51:
Line 52: if (customValues != null) {
Line 53: for (Entry<String, String> entry :
customValues.entrySet()) {
Line 54: logable.addCustomValue(entry.getKey(),
entry.getValue());
--
To view, visit http://gerrit.ovirt.org/15177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2858ded9cfac2dc6df03928b90469876878aa94d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
