Sahina Bose has posted comments on this change.
Change subject: gluster: Gluster Sync job event log corrected
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 642: }
Line 643: }
Line 644:
Line 645: private void updateExistingOptions(final GlusterVolumeEntity
volume, Collection<GlusterVolumeOptionEntity> entities) {
Line 646: getOptionDao().updateAll("UpdateGlusterVolumeOption",
entities);
You may want to move this update call down, as you want to show old value in
the log message
Line 647: for (final GlusterVolumeOptionEntity entity : entities) {
Line 648: logUtil.logAuditMessage(volume.getClusterId(), volume,
null,
Line 649:
AuditLogType.GLUSTER_VOLUME_OPTION_CHANGED_FROM_CLI,
Line 650: new HashMap<String, String>() {
--
To view, visit http://gerrit.ovirt.org/15172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ed05a8ef5faec8202b79fe0037482d956f3fed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
