Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added postinstall file creation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/postinstall.py Line 50: name=osetupcons.FileLocations.OVIRT_SETUP_POST_INSTALL_CONFIG, Line 51: ) Line 52: ) Line 53: content = ['[environment:default]'] Line 54: for c in osetupcons.__dict__['__osetup_attrs__']: we should probably by now move this to utilities and squash this loop from at least 3 locations. Line 55: for k in c.__dict__.values(): Line 56: if hasattr(k, '__osetup_attrs__'): Line 57: if k.__osetup_attrs__['postinstallfile']: Line 58: k = k.fget(None) -- To view, visit http://gerrit.ovirt.org/15957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3516d6b9b29d50844835bb67c0a4a3f5485aa21f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
