Sandro Bonazzola has posted comments on this change.

Change subject: packaging: build: fix make rpm target
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File Makefile
Line 263: rpm:  srpm
Line 264:       rm -rf "$(OUTPUT_RPMBUILD)"
Line 265:       mkdir -p 
"$(OUTPUT_RPMBUILD)"/{SPECS,RPMS,SRPMS,SOURCES,BUILD,BUILDROOT}
Line 266:       mkdir -p "$(OUTPUT_DIR)"
Line 267:       $(RPMBUILD) --define="_topdir $(OUTPUT_RPMBUILD)" 
$(RPMBUILD_EXTRA_ARGS) "$(OUTPUT_DIR)/$(PACKAGE_NAME)-$(RPM_VERSION)"*.src.rpm
missing --rebuild here
Line 268:       mv $(OUTPUT_RPMBUILD)/RPMS/$(ARCH)/*.rpm "$(OUTPUT_DIR)"
Line 269:       rm -rf "$(OUTPUT_RPMBUILD)"
Line 270:       @echo
Line 271:       @echo rpms are ready at $(OUTPUT_DIR)


-- 
To view, visit http://gerrit.ovirt.org/15963
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4632c1dd2007d2b513f59e08846da7d8030b8865
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to