Mike Kolesnik has posted comments on this change.
Change subject: providers: add the onAddition and onRemoval hooks
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java
Line 43: @Override
Line 44: protected void executeCommand() {
Line 45: getProvider().setId(Guid.NewGuid());
Line 46:
Line 47: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Object>() {
Why execute in new transaction?
The command is already transactional (by default, unless NonTransactional
annotation is used).
Line 48: @Override
Line 49: public Object runInTransaction() {
Line 50: getDbFacade().getProviderDao().save(getProvider());
Line 51:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxy.java
Line 18: * @return List of Certificate objects
Line 19: */
Line 20: List<? extends Certificate> getCertificateChain();
Line 21:
Line 22: void onAddition();
Please add javadoc to these methods
Line 23:
Line 24: void onRemoval();
Line 25:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java
Line 51: @Override
Line 52: protected void executeCommand() {
Line 53: final Guid providerId = getParameters().getProvider().getId();
Line 54:
Line 55: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Object>() {
Same as in AddProviderCommand
Line 56: @Override
Line 57: public Object runInTransaction() {
Line 58: ProviderProxy providerProxy =
ProviderProxyFactory.getInstance().create(getParameters().getProvider());
Line 59:
--
To view, visit http://gerrit.ovirt.org/15896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b9a9af042ebd7988d90afeeecec4905a704894b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
