Alon Bar-Lev has posted comments on this change.
Change subject: webadmin: add feedback image to webadmin
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
Line 24:
Line 25: HasClickHandlers getConfigureLink();
Line 26:
Line 27: HasClickHandlers getAboutLink();
Line 28:
Done
Line 29: void setFeedbackLink(String feedbackLink);
Line 30: }
Line 31:
Line 32: @ContentSlot
Line 46: WebAdminConfigurator.DOCUMENTATION_GUIDE_PATH,
dynamicMessages.applicationDocTitle());
Line 47: this.searchPanel = searchPanel;
Line 48: this.aboutPopup = aboutPopup;
Line 49: this.configurePopup = configurePopup;
Line 50: getView().setFeedbackLink(dynamicMessages.feedbackUrl());
Done
Line 51: }
Line 52:
Line 53: @Override
Line 54: public void addTabWidget(Widget tabWidget, int index) {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
Line 93: localize(dynamicMessages);
Line 94:
Line 95: feedbackImage.setVisible(false);
Line 96:
Line 97: feedbackImage.addClickHandler(new ClickHandler() {
Done
BTW: it was this way in the original patch... :)
Line 98:
Line 99: @Override
Line 100: public void onClick(ClickEvent event) {
Line 101: if (feedbackLink != null && feedbackLink.length() >
0) {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
Line 29: }
Line 30:
Line 31: .menuBar {
Line 32: float: right;
Line 33: padding: 10px 140px 10px 10px;
Done
Line 34: }
Line 35:
Line 36: .userName {
Line 37: font-weight: bold;
--
To view, visit http://gerrit.ovirt.org/15984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic804e1ec2a7365898db7013a09639a2096a76184
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
