Alex Lourie has posted comments on this change. Change subject: packaging: setup: upgrade firewall configuration ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 161: self.services.status(manager) Line 162: ): Line 163: self.environment[ Line 164: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 165: ] = manager should break here inside 'if'? Line 166: Line 167: if self.environment[osetupcons.ConfigEnv.FIREWALL_MANAGER] is None: Line 168: for manager in managers: Line 169: response = self.dialog.queryString( -- To view, visit http://gerrit.ovirt.org/15978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I019c2a5deecaa8aaac0fdd9b0fc84555ce0e99ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
