Moti Asayag has posted comments on this change.
Change subject: engine: Add support for vNICs in OpenstackNetwork
......................................................................
Patch Set 24: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java
Line 90: @Override
Line 91: public Map<String, String> allocate(Network network,
VmNetworkInterface nic) {
Line 92: deallocate(nic);
Line 93: try {
Line 94: com.woorea.openstack.quantum.model.Network quantumNetwork =
please omit the 'quantum' from the property name: quantumNetwork
Line 95:
getClient().networks().show(network.getProvidedBy().getExternalId()).execute();
Line 96: PortForCreate port = new PortForCreate();
Line 97: port.setAdminStateUp(true);
Line 98: port.setName(nic.getName());
--
To view, visit http://gerrit.ovirt.org/11110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I465dee81c3348a3f49ff41a8983a8ba2c8d43fad
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
