Arik Hadas has posted comments on this change.
Change subject: 7. core : Change AddVmTemplateCommand
......................................................................
Patch Set 21: Looks good to me, but someone else must approve
(1 inline comment)
minor comment, besides that looks good to me
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 123:
Line 124: protected void updateVmDisks() {
Line 125: VmHandler.updateDisksFromDb(getVm());
Line 126: for (DiskImage diskImage : getVm().getDiskList()) {
Line 127: mImages.add(diskImage);
why not just mImages.addAll(getVm().getDiskList()) ?
Line 128: }
Line 129: }
Line 130:
Line 131: @Override
--
To view, visit http://gerrit.ovirt.org/15562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d61e6b2a0f7967bcee463ff2384cb6daba892b9
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
