Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Shown command and server name in evt log
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
Gave minor suggestion, if you don't want to change this, this is fine.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 275: return fetchedServers;
Line 276: }
Line 277:
Line 278: private void setNonOperational(VDS server) {
Line 279: Map<String, String> customValues = new HashMap<String,
String>();
Collections.singltonMap ?
Line 280: customValues.put(GlusterConstants.COMMAND, "gluster peer
probe");
Line 281: SetNonOperationalVdsParameters nonOpParams =
Line 282: new SetNonOperationalVdsParameters(server.getId(),
NonOperationalReason.GLUSTER_COMMAND_FAILED, customValues);
Line 283: nonOpParams.setSaveToDb(true);
--
To view, visit http://gerrit.ovirt.org/15794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5857284b76a56f8b6b3cb8431a6997443939bb8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
