Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Log setup/cleanup/upgrade actions
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File packaging/bin/ovirt-engine-log-setup-event.sh.in
Line 52: esac
Line 53: done
Line 54:
Line 55: get_distro_name() {
Line 56: python -c 'import platform; print
platform.linux_distribution(full_distribution_name=0)[0]'
why not just search for the tool?
the fact that distro rely on python does not mean this script should. It should
reply on the tools it uses.
Line 57: }
Line 58:
Line 59: get_distro_packages() {
Line 60: distro=$(get_distro_name)
Line 75: prefix_cmd(){
Line 76: prefix="$1"
Line 77: shift
Line 78: "$@" 2>&1 | sed "s/^/${prefix}: /"
Line 79: }
oh... so this prefix_cmd can be:
echo -n "${prefix} "
shift
"$@" 2>&1
?
Line 80:
Line 81: (
Line 82: echo SETUP-EVENT-BEGIN
Line 83: prefix_cmd DATE date +'%Y-%m-%d %H:%M:%S'
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
