Oved Ourfali has uploaded a new change for review. Change subject: findbugs - check for null on a already dereferenced variable ......................................................................
findbugs - check for null on a already dereferenced variable No need to check for null, as it cannot be null. Change-Id: I86f454d2cff51b249745fb508ff547528538a21c Signed-off-by: Oved Ourfali <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/16034/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java index 4a8d031..2b589a3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java @@ -393,8 +393,7 @@ log.errorFormat("Failed to {0} VDS using {1} Power Management agent", getParameters().getAction() .name() .toLowerCase(), order.name()); - Throwable vdsReturnValueException = vdsReturnValue != null? vdsReturnValue.getExceptionObject() : null; - AlertIfPowerManagementOperationSkipped(getParameters().getAction().name(), vdsReturnValueException); + AlertIfPowerManagementOperationSkipped(getParameters().getAction().name(), vdsReturnValue.getExceptionObject()); throw new VdcBLLException(VdcBllErrors.VDS_FENCE_OPERATION_FAILED); } else { // Fence operation was skipped because Host is already in the requested state. setStatus(lastStatus); -- To view, visit http://gerrit.ovirt.org/16034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86f454d2cff51b249745fb508ff547528538a21c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
