Daniel Erez has posted comments on this change.
Change subject: webadmin: add memory option to create snapshot popup
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java
Line 53:
Line 54: private final Driver driver = GWT.create(Driver.class);
Line 55:
Line 56: public VmSnapshotCreatePopupWidget(CommonApplicationConstants
constants) {
Line 57: memoryEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
It would be nicer to extract it to an init method (e.g. initEditors())
Line 58: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this));
Line 59: localize(constants);
Line 60: ViewIdHandler.idHandler.generateAndSetIds(this);
Line 61: driver.initialize(this);
Line 81: updateMemoryBoxVisibility();
Line 82: }
Line 83: }
Line 84:
Line 85: private void updateMemoryBoxVisibility() {
no reason for an inner method - extract it to a class method...
Line 86: VM vm = model.getVm();
Line 87: if (vm == null) {
Line 88: return;
Line 89: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java
Line 322:
Line 323: VM vm = getVm();
Line 324: ArrayList<VdcActionParametersBase> params = new
ArrayList<VdcActionParametersBase>();
Line 325: CreateAllSnapshotsFromVmParameters param =
Line 326: new CreateAllSnapshotsFromVmParameters(vm.getId(),
formatter
Line 327: (String)
getDescription().getEntity(),
Line 328: (Boolean)
getMemory().getEntity());
Line 329: param.setQuotaId(vm.getQuotaId());
Line 330: params.add(param);
--
To view, visit http://gerrit.ovirt.org/15685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab771d2f9ae18e7812fe8ee9806a65cbb6576a21
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
