Allon Mureinik has posted comments on this change.
Change subject: core: WIP: avoid having LOCKED domain on a failed reconstruct.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(4 inline comments)
Not a big fan of this approach, but I could not find a better one.
+1.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
Line 59: return false;
Line 60: }
Line 61:
Line 62: @Override
Line 63: protected boolean canDoAction() {
please add javadoc to explain this.
Line 64: if
(checkIsDomainLocked(getStorageDomain().getStoragePoolIsoMapData())) {
Line 65: return false;
Line 66: }
Line 67:
....................................................
Commit Message
Line 6:
Line 7: core: WIP: avoid having LOCKED domain on a failed reconstruct.
Line 8:
Line 9: When the reconstruct command is being executed during its CDA phase
Line 10: the pool domains statuses are loaded and are checked for being
different
pool's domains' statuses
Line 11: then LOCKED.
Line 12: getStorageDomain() is being called prior to the CDA check from
Line 13: getJobMessageProperties(), which means that possibly the loaded domain
Line 14: would be in status LOCKED.
Line 15:
Line 16: In case of using compensation through reconstruct, the domain status
Line 17: might be reverted to LOCKED instead of to it's actual status.
Line 18:
Line 19: This patch only verifies that the loaded domain withing
s/withing/within/
Line 20: getStorageDomain() isn't LOCKED, a further behaviour change might be
Line 21: needed generally.
Line 22:
Line 23: Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Line 18:
Line 19: This patch only verifies that the loaded domain withing
Line 20: getStorageDomain() isn't LOCKED, a further behaviour change might be
Line 21: needed generally.
Line 22:
Bur-Url ?
Related-to ?
Line 23: Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
--
To view, visit http://gerrit.ovirt.org/16043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf13f36f30d4cf48e8517444a33bab6359416d37
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
