Tomas Jelinek has posted comments on this change. Change subject: engine: pooled VMs has to be always sysprepped ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java Line 206: runVmParams.setUseVnc(getVm().getVmType() == VmType.Server); Line 207: runVmParams.setParentParameters(getParameters()); Line 208: runVmParams.setEntityId(vmToAttach); Line 209: // always do sysprep for pooled machines Line 210: runVmParams.setReinitialize(true); well, this is not correct - especially not for non-windows machines Line 211: runVmParams.setParentCommand(VdcActionType.AttachUserToVmFromPoolAndRun); Line 212: runVmParams.setRunAsStateless(true); Line 213: ExecutionContext runVmContext = createRunVmContext(); Line 214: VdcReturnValueBase vdcReturnValue = Backend.getInstance().runInternalAction(VdcActionType.RunVm, -- To view, visit http://gerrit.ovirt.org/16060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65c69514e3edd02ff44685f58bccd7f0674ef8dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
