Sandro Bonazzola has posted comments on this change.

Change subject: [WIP] packaging: Added postgres listening external network
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File packaging/common_utils.py
Line 67: FILE_ENGINE_PRIVATE = '/etc/pki/ovirt-engine/private/ca.pem'
Line 68: FILE_IPTABLES_DEFAULT = '/usr/share/ovirt-dwh/iptables.default.in'
Line 69: FILE_IPTABLES_BACKUP = '/var/lib/ovirt-engine/backups/iptables.backup'
Line 70: 
Line 71: # TODO: Support SystemD services
For this I think you can reuse something from http://gerrit.ovirt.org/#/c/11228/
Line 72: class Service():
Line 73:     def __init__(self, name):
Line 74:         self.wasStopped = False
Line 75:         self.wasStarted = False


Line 1017:     iptables = Service("iptables")
Line 1018:     fwd = Service("firewalld")
Line 1019: 
Line 1020:     # Add available services to list
Line 1021:     if fwd.available() and firewalld.isPermanentSupported():
firewalld undefined
Line 1022:         firewalls.append("firewalld")
Line 1023:     if iptables.available():
Line 1024:         firewalls.append("iptables")
Line 1025: 


-- 
To view, visit http://gerrit.ovirt.org/15964
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdd133a392fb3dba6088a9fb12ce4ca828f24073
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to