Frank Kobzik has posted comments on this change.
Change subject: backend: Make adding (virtio-)console to virtual machines
optional
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 96: if (parameters.getVmStaticData() != null) {
Line 97: setVmTemplateId(parameters.getVmStaticData().getVmtGuid());
Line 98: }
Line 99:
Line 100: if (parameters.isConsoleEnabled() == null) {
We agreed that it should be nullable after all since it is shared with
UpdateVmCommand where null has sense.
Line 101: parameters.setConsoleEnabled(false);
Line 102: }
Line 103:
Line 104: parameters.setEntityId(getVmId());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
Line 104: }
Line 105:
Line 106: if (getParameters().isConsoleEnabled() == null) {
Line 107: parameters.setConsoleEnabled(false);
Line 108: }
Similar as previously commented class.
Line 109:
Line 110: }
Line 111:
Line 112: protected void updateVmDisks() {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 349: }
Line 350:
Line 351: @Override
Line 352: protected void buildVmConsoleDevice() {
Line 353: buildVmDevicesFromDb(VmDeviceGeneralType.CONSOLE, false);
(So in the end console device doesn't have an address.)
Line 354: }
Line 355:
Line 356: private void buildVmDevicesFromDb(VmDeviceGeneralType
generalType, boolean addAddress) {
Line 357: List<VmDevice> vmDevices =
--
To view, visit http://gerrit.ovirt.org/15554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d913b1fca9d064424aab58d4c34ec3e4b246373
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
