Yair Zaslavsky has posted comments on this change.
Change subject: engine: Unify Guid and NGuid
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java
Line 63: return new Guid(candidate);
Line 64: }
Line 65: }
Line 66:
Line 67: public static Guid createGuidFromStringDefaultEmpty(String
candidate) {
I don't like this method name.
Perhaps -
createGuidFromString(String candidate, boolean useEmptyIfNull) - and have
createGuidFromString(String candidate) call
createGuidFromString(candidate,false) and use
createGuidFromString(candidate,true) in all places you intended to use the
method that ends with DefaultEmpty?
Line 68: if (candidate == null) {
Line 69: return Guid.Empty;
Line 70: } else {
Line 71: return new Guid(candidate);
--
To view, visit http://gerrit.ovirt.org/15691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4af6d353ef27394ff902f374de19682628c52739
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
