Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added upgrade from legacy plugin ......................................................................
Patch Set 8: (3 inline comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 124: LEGACY_OVIRT_ENGINE_SYSCONFIG = os.path.join( Line 125: SYSCONFDIR, Line 126: 'sysconfig', Line 127: 'ovirt-engine', Line 128: ) are you sure this was not resolved in 3.2? Line 129: Line 130: LEGACY_PSQL_PASS_FILE = os.path.join( Line 131: OVIRT_ENGINE_SYSCONFDIR, Line 132: '.pgpass', .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/__init__.py Line 24: Line 25: from . import misc Line 26: from . import uninstall Line 27: from . import postinstall Line 28: from . import legacy I don't want to cause you more work, but I think this belongs in its own plugin not in core. Then you can split it to httpd, engine, ... Line 29: Line 30: Line 31: @util.export Line 32: def createPlugins(context): .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/legacy.py Line 51: storage, Line 52: storage_name Line 53: from storage_domain_static Line 54: where Line 55: storage_type=4 and can you please add constants to these? the name of the constant in application. Line 56: storage_domain_type=0 Line 57: """, Line 58: ownConnection=True, Line 59: ) -- To view, visit http://gerrit.ovirt.org/15975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ee25f561218d83c5a4bd821c2d89587df5bc47a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
