Kanagaraj M has uploaded a new change for review.

Change subject: webadmin: Fix NPE in cluster gluster services view
......................................................................

webadmin: Fix NPE in cluster gluster services view

Some of the gluster services may not have port number present,
so adding null check for it.

Change-Id: Ic6c69207238d7553abafbcb9c1ffe7eb81897e64
Bug-Url: https://bugzilla.redhat.com/885592
Signed-off-by: Kanagaraj M <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/16177/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
index a60f2db..1b84b62 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
@@ -139,7 +139,7 @@
         servicesTable.addEntityModelColumn(new 
EntityModelTextColumn<GlusterServerService>() {
             @Override
             public String getText(GlusterServerService entity) {
-                if (entity.getPort() > 0) {
+                if (entity.getPort() != null && entity.getPort() > 0) {
                     return String.valueOf(entity.getPort());
                 }
                 else {


-- 
To view, visit http://gerrit.ovirt.org/16177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6c69207238d7553abafbcb9c1ffe7eb81897e64
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to