Tomas Jelinek has uploaded a new change for review. Change subject: frontend: fix findbugs issue ......................................................................
frontend: fix findbugs issue Possible NPE - the vm can be null. Code which expected it to be not null moved to the due if statement. Change-Id: I62b9e55f005b183ac4cdc642ebf5cfff4d125810 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/92/16192/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java index 03ad782..09c5da3 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java @@ -277,6 +277,7 @@ model.getTemplate().setIsChangable(false); cdImage = vm.getIsoPath(); + model.getVmType().setSelectedItem(vm.getVmType()); } else { @@ -293,8 +294,6 @@ if (hasCd) { model.getCdImage().setSelectedItem(cdImage); } - - model.getVmType().setSelectedItem(vm.getVmType()); model.getProvisioning().setIsChangable(false); model.getStorageDomain().setIsChangable(false); -- To view, visit http://gerrit.ovirt.org/16192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62b9e55f005b183ac4cdc642ebf5cfff4d125810 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
