Sandro Bonazzola has posted comments on this change.
Change subject: network: firewalld: support firewall-cmd >= 0.3
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 42
Line 43
Line 44
Line 45
Line 46
yes, I think so. can you give me the version in Fedora 17 which doesn't have
--permanent?
Line 42:
Line 43: """
Line 44:
Line 45: FIREWALLD_SERVICES_DIR = '/etc/firewalld/services'
Line 46: _ZONE_RE = re.compile(r'\w+')
ok, I'll fix that
Line 47: _INTERFACE_RE = re.compile(
Line 48: flags=re.VERBOSE,
Line 49: pattern=r"""
Line 50: \s+
Line 77: self.command.get('firewall-cmd'),
Line 78: '--version',
Line 79: ),
Line 80: )
Line 81: return stdout[0].split('.')
Do you mean returning '000000030000' or int('000000030000') ?
Line 82:
Line 83: def _get_active_zones(self):
Line 84: rc, stdout, stderr = self.execute(
Line 85: (
--
To view, visit http://gerrit.ovirt.org/16094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
