Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: added upgrade from legacy plugins
......................................................................


Patch Set 14: (7 inline comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 924:     MINIMUM_SPACE_STORAGEDOMAIN_MB = 10240
Line 925: 
Line 926: 
Line 927: @util.export
Line 928: class StorageDomainType(object):
Done, moved to domains.py
Line 929:     #See: 
org.ovirt.engine.core.common.businessentities.StorageDomainType
Line 930:     MASTER = 0
Line 931:     DATA = 1
Line 932:     ISO = 2


....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/apache.py
Line 47:         ],
Line 48:     )
Line 49:     def _misc(self):
Line 50:         if (
Line 51:             not self.environment[osetupcons.CoreEnv.DEVELOPER_MODE] and
Done
Line 52:             os.path.exists(
Line 53:                 osetupcons.FileLocations.HTTPD_CONF_OVIRT_ENGINE_LEGACY
Line 54:             )
Line 55:         ):


....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/config.py
Line 44:     @plugin.event(
Line 45:         stage=plugin.Stages.STAGE_INIT,
Line 46:     )
Line 47:     def _init(self):
Line 48:         self.environment[osetupcons.CoreEnv.UPGRADE_FROM_LEGACY] = (
Done
Line 49:             os.path.exists(
Line 50:                 
osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT
Line 51:             ) and
Line 52:             not os.path.exists(


....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/datadomain.py
Line 65:                 storage_name
Line 66:                 from storage_domain_static
Line 67:                 where
Line 68:                 storage_type=%(storage_type)s and
Line 69:                 storage_domain_type=%(storage_domain_type)s
Done
Line 70:             """,
Line 71:             args=dict(
Line 72:                 storage_type=osetupcons.StorageType.LOCALFS,
Line 73:                 
storage_domain_type=osetupcons.StorageDomainType.MASTER,


Line 80:                     select
Line 81:                     connection
Line 82:                     from storage_server_connections
Line 83:                     where
Line 84:                     id=%(storage)s
Done
Line 85:                 """,
Line 86:                 args=dict(
Line 87:                     storage=domain['storage']
Line 88:                 ),


....................................................
File packaging/setup/plugins/ovirt-engine-setup/legacy/isodomain.py
Line 64:                 storage_name
Line 65:                 from storage_domain_static
Line 66:                 where
Line 67:                 storage_type=%(storage_type)s and
Line 68:                 storage_domain_type=%(storage_domain_type)s
Done
Line 69:             """,
Line 70:             args=dict(
Line 71:                 storage_type=osetupcons.StorageType.NFS,
Line 72:                 storage_domain_type=osetupcons.StorageDomainType.ISO,


Line 79:                     select
Line 80:                     connection
Line 81:                     from storage_server_connections
Line 82:                     where
Line 83:                     id=%(storage)s
Done
Line 84:                 """,
Line 85:                 args=dict(
Line 86:                     storage=domain['storage']
Line 87:                 ),


-- 
To view, visit http://gerrit.ovirt.org/15975
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee25f561218d83c5a4bd821c2d89587df5bc47a
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to