Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] Introduce new directory interface
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/auth/src/main/java/org/ovirt/engine/core/directory/DirectoryManager.java
Line 129: }
Line 130:
Line 131: // Enumerate and load the files:
Line 132: File[] files = directory.listFiles();
Line 133: Arrays.sort(files);
Why do we need to sort?
Line 134: for (File file : files) {
Line 135: if (file.getName().endsWith(".properties")) {
Line 136: Directory instance = loadInstance(file);
Line 137: if (instance == null) {
Line 165: private Directory loadInstance(File file) {
Line 166: // Load the properties from the file:
Line 167: Properties configuration = new Properties();
Line 168: InputStream in = null;
Line 169: try {
autoclosable syntax?
Line 170: in = new FileInputStream(file);
Line 171: configuration.load(in);
Line 172: }
Line 173: catch (IOException exception) {
--
To view, visit http://gerrit.ovirt.org/15596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If84a0c9d6553d81cdbbe224972696f169cca90d4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
