Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: Frontend refactor[WIP] ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java Line 1237 Line 1238 Line 1239 Line 1240 Line 1241 I prefer to keep the current hash check in all relevant files. It's still needed for making sure the query originated from the same model instance. Should be removed only after a proper alternative mechanism is introduced... -- To view, visit http://gerrit.ovirt.org/15399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dae5a455ad16660b97cddafba53b53d3b4196f1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
